Best Practices

Code Review Checklist

Before we commit code to source control, we check it for compliance. Is your team implementing code review as part of their process? Download the checklist.

This checklist includes:

General Code Smoke Test
Does the code build correctly? Execute as expected? Is it understandable?

Comments and Coding Conventions
Are project coding conventions respected? Variable declarations properly commented?

Error Handling
Are all thrown exceptions handled properly? Is the function caller notified when an error is detected?

Resource Leaks
Is allocated memory freed? Are objects released more than once?

Thread Safeness
Are all global variables thread-safe? Possible deadlock or lock contention?

Control Structures
Are loop ending conditions accurate? No unintended infinite loops?

Performance
Do recursive functions run within a reasonable amount of stack space? Are you using blocking system calls?

Functions
Are function parameters explicitly verified? Are arrays checked for out-of-bound indexes?

Bug Fixes
Does a fix made to a function change the behavior of caller functions?

Math
Is the code doing signed/unsigned conversions?

Download the complete code review checklist.